Date index for Jul 2003


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [achievo] Themes



In article <DBE9136FA7B2D51180F00008C791E29E079A4DAD dot 
Beguiristain <robertb dot 
>Thank you very much for your effort and time, however, I think there may
>have been some misunderstanding. What I have done is built a module that
>uses ATK's native ability to create dynamic styles sheets via $g_theme to
>customize their selected themes. The problem, I have with some of these
>themes is that they have inline fonts, background colors and such that are
>not created using the "layout.inc" file. These all appears to all come from
>the .tmpl files. If they were designed to fully utilize the styles created
>by the "layout.inc" file, I would be able to give my users a fully
>customizable layout. So what I am suggesting is that only styles be used and
>that they all be created via the "layout.inc" file, so that it will be
>possible to use $g_theme to fully control them.

The hardcoded fonts are scattered all through Achievo.  If you look at
the patch I created you'll see that I added a number of classes to the
end of styles.php which has removed a lot of the hardcoded font details
from the main part of Achievo (ATK and the modules).  Once things are in
styles.php it's quick and simple to adjust them, whether to other
hardcoded values or $g_theme.

The calendar and theme specific styles haven't been converted to classes
yet but now they're using CSS rather than HTML it's nearly done.  The
main reason I haven't converted them yet is because I haven't had a
chance to confirm everything does what it's supposed to.  I simply
wasn't going to put the effort into fiddling with the individual themes
until I was certain that things weren't misbehaving, that's why 95% of
those patches has been sitting on my drive doing nothing for a while
now.

If the patches work okay then I'll start integrating them into
styles.php (and therefore layout.inc) although some of the changes
probably require a chat with Ivo first.  Of course there's still a need
to track down the various other tags which can be converted to
styles/classes too, I basically just took pot-shots at font tags and
anything close enough to attract my attention.

Kevin
-- 
kevin dot 

http://www.achievo.org/lists achievo.org - ©1999-2002 ibuildings.nl BV